-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config.build
should be inheritable
#588
Comments
I think making
where various env specific constants etc could be defined. |
And we have already agreed for We have deprecated the Although I note in the code, we are just grabbing the rules from the top-level environment and ignoring the current environment. I think this might be a problem across the codebase for other properties; or at least it is a potential foot-gun. |
…vironment" Now the `build` field can be specified within a named environment, overriding whatever may appear at the top level. Resolves cloudflare#588
…vironment" Now the `build` field can be specified within a named environment, overriding whatever may appear at the top level. Resolves #588
config.build
should be inheritable/redefinable across environments (which makes sense, because builds/build commands are typically different across environments; different vars, params, etc.). I think wrangler1 supports this.This is a bit tricky because this might imply that
main
/rules
should be inheritable. Maybe it should be. But it would be nice if this combination would work:main
build
build
(that outputs to top levelmain
)main
I spent a few minutes on this but got confused, so I'm filing this issue instead for now.
main
an inheritable environment field #650build
field to be inherited/overridden in a named environment #673The text was updated successfully, but these errors were encountered: