Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve experience with multiple accounts #435

Closed
Electroid opened this issue Feb 10, 2022 · 1 comment
Closed

Improve experience with multiple accounts #435

Electroid opened this issue Feb 10, 2022 · 1 comment
Labels
polish Small improvements to the experience

Comments

@Electroid
Copy link
Contributor

If your credentials have access to multiple accounts, it becomes annoying to use the account selector on each run. Ideally, we should only ask for an account ID, once per project. Here's what that might look like:

  • If an account_id is specified in the wrangler.toml, that is always used.
    • Give a friendly error if the credentials don't have access to that account_id.
  • If no account_id is specified:
    • If credentials have access to 1 account, continue with that account, but don't append the account_id.
    • If credentials have access to multiple accounts, prompt for an account, then append account_id to the wrangler.toml.
@Electroid Electroid added the polish Small improvements to the experience label Feb 10, 2022
@Electroid Electroid added this to the 2.0 milestone Feb 10, 2022
@Electroid Electroid moved this to Should-have in workers-sdk Feb 10, 2022
@threepointone threepointone removed this from the 2.0 milestone Mar 26, 2022
@petebacondarwin
Copy link
Contributor

Everything except for the following has been done here.

then append account_id to the wrangler.toml.

This is because we are not currently in a position to automatically update the wrangler.toml, which is being tracked in #74

Repository owner moved this from Should-have to Done in workers-sdk May 4, 2022
mrbbot added a commit that referenced this issue Oct 31, 2023
@mrbbot
Add support for built-in workerd services (#435)
37e7b04 
Specifically, this allows custom `network`, `external` and `disk`
services to be specified as service bindings. Requests to `network`
services are dispatched according to URL. Requests to `external`
services are dispatched to the specified remote server. Requests to
`disk` services are dispatched to an HTTP service backed by an
on-disk directory.

This PR also fixes a bug where custom function service bindings with
the same name in different Workers would dispatch all requests to the
first Workers' function.
mrbbot added a commit that referenced this issue Nov 1, 2023
@mrbbot
Add support for built-in workerd services (#435)
b094c79 
Specifically, this allows custom `network`, `external` and `disk`
services to be specified as service bindings. Requests to `network`
services are dispatched according to URL. Requests to `external`
services are dispatched to the specified remote server. Requests to
`disk` services are dispatched to an HTTP service backed by an
on-disk directory.

This PR also fixes a bug where custom function service bindings with
the same name in different Workers would dispatch all requests to the
first Workers' function.
mrbbot added a commit that referenced this issue Nov 1, 2023
@mrbbot
Add support for built-in workerd services (#435)
e88c4ae 
Specifically, this allows custom `network`, `external` and `disk`
services to be specified as service bindings. Requests to `network`
services are dispatched according to URL. Requests to `external`
services are dispatched to the specified remote server. Requests to
`disk` services are dispatched to an HTTP service backed by an
on-disk directory.

This PR also fixes a bug where custom function service bindings with
the same name in different Workers would dispatch all requests to the
first Workers' function.
mrbbot added a commit that referenced this issue Nov 1, 2023
@mrbbot
Add support for built-in workerd services (#435)
b1e1fa9 
Specifically, this allows custom `network`, `external` and `disk`
services to be specified as service bindings. Requests to `network`
services are dispatched according to URL. Requests to `external`
services are dispatched to the specified remote server. Requests to
`disk` services are dispatched to an HTTP service backed by an
on-disk directory.

This PR also fixes a bug where custom function service bindings with
the same name in different Workers would dispatch all requests to the
first Workers' function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
polish Small improvements to the experience
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@petebacondarwin @threepointone @Electroid