Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 BUG: 404 on Remix #379

Closed
isaac-mcfadyen opened this issue Feb 3, 2022 · 4 comments · Fixed by #350
Closed

🐛 BUG: 404 on Remix #379

isaac-mcfadyen opened this issue Feb 3, 2022 · 4 comments · Fixed by #350
Labels
pages Relating to Pages

Comments

@isaac-mcfadyen
Copy link
Contributor

What version of Wrangler are you using?

0.0.15

What operating system are you using?

MacOS

Describe the Bug

404 errors are occuring with the Remix Cloudflare Pages adapter (specifically, any page visited gives a 404, regardless of whether it exists or not). Issue was originally opened on Remix but looks to be related to Wrangler instead: remix-run/remix#1793

This error does not occur with 0.0.14; looks like a regression.
@petebacondarwin petebacondarwin added the pages Relating to Pages label Feb 3, 2022
@GregBrimble
Copy link
Member

This is actually a problem with the current alpha vs. 0.0.15 (beta). We'll dig into it. Thanks for the report!

@GregBrimble
Copy link
Member

Regression in e151223

petebacondarwin added a commit that referenced this issue Feb 3, 2022
@petebacondarwin
fix: ensure pages routes are defined correctly
522d1d3 
In e151223 we introduced a bug where the RouteKey was now an array rather than a simple URL string. When it got stringified into the routing object these were invalid.
E.g. `[':page*', undefined]` got stringified to `":page*,"` rather than `":page*"`.

Fixes #379
petebacondarwin added a commit that referenced this issue Feb 3, 2022
@petebacondarwin
fix: ensure pages routes are defined correctly
6233b40 
In e151223 we introduced a bug where the RouteKey was now an array rather than a simple URL string. When it got stringified into the routing object these were invalid.
E.g. `[':page*', undefined]` got stringified to `":page*,"` rather than `":page*"`.

Fixes #379
petebacondarwin added a commit that referenced this issue Feb 3, 2022
@petebacondarwin
fix: ensure pages routes are defined correctly
b1f4154 
In e151223 we introduced a bug where the RouteKey was now an array rather than a simple URL string. When it got stringified into the routing object these were invalid.
E.g. `[':page*', undefined]` got stringified to `":page*,"` rather than `":page*"`.

Fixes #379
petebacondarwin added a commit that referenced this issue Feb 4, 2022
@petebacondarwin
fix: ensure pages routes are defined correctly
ea538f7 
In e151223 we introduced a bug where the RouteKey was now an array rather than a simple URL string. When it got stringified into the routing object these were invalid.
E.g. `[':page*', undefined]` got stringified to `":page*,"` rather than `":page*"`.

Fixes #379
@github-actions github-actions bot mentioned this issue Feb 4, 2022
Merged
@petebacondarwin
Copy link
Contributor

@mcfadyeni - we have merged #380 into main. Can you try out wrangler@alpha to see if that has fixed this problem? We will do a beta release early next week.

@isaac-mcfadyen
Copy link
Contributor Author

Confirmed that it is fixed on wrangler@alpha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pages Relating to Pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Version Packages cloudflare/workers-sdk
3 participants
@petebacondarwin @isaac-mcfadyen @GregBrimble