-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve and standardize output to stderr #377
Labels
polish
Small improvements to the experience
Comments
This was referenced Mar 31, 2022
petebacondarwin
added a commit
to petebacondarwin/wrangler2
that referenced
this issue
Apr 26, 2022
petebacondarwin
added a commit
to petebacondarwin/wrangler2
that referenced
this issue
Apr 26, 2022
petebacondarwin
added a commit
to petebacondarwin/wrangler2
that referenced
this issue
Apr 27, 2022
petebacondarwin
added a commit
that referenced
this issue
Apr 27, 2022
* polish: improve consistency of warnings and errors Related to #377
Merged
#848 actually implements the esbuild formatting for errors and warnings. So I think we can close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Our current output to stderr is usually hard to read. There's also no standard format, so it's all over the place depending on the error and context. If we compare it to the output that esbuild prints, it's hard to compare.
wrangler, when you upload a script that throws an error on startup:
esbuild, when you try to upload a script with syntax errors:
The format that esbuild uses is actually really nice, maybe we could adopt a similar (or same) format? Here's the algorithm it uses to generate that format.
Edit: It looks like esbuild actually exposes an API to format text in its format. We could use that.
The text was updated successfully, but these errors were encountered: