Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r2 bucket support #365

Closed
1 of 5 tasks
Tracked by #151
petebacondarwin opened this issue Feb 1, 2022 · 0 comments · Fixed by #452 or #407
Closed
1 of 5 tasks
Tracked by #151

r2 bucket support #365

petebacondarwin opened this issue Feb 1, 2022 · 0 comments · Fixed by #452 or #407
Assignees
@petebacondarwin

Comments

@petebacondarwin
Copy link
Contributor

petebacondarwin commented Feb 1, 2022 •
edited
Loading

Adding support for R2 bindings and commands, as defined in cloudflare/wrangler-legacy@6408b15

The implementation is the minimum to match what is provided by Wrangler 1 right now.
Before GA we should consider some polish such as:

  • Ask before deleting a bucket
  • Support bindings to preview buckets
  • After bucket creation, provide guidance on how to configure a binding in the wrangler.toml
@petebacondarwin petebacondarwin mentioned this issue Feb 1, 2022
Closed
10 tasks
@petebacondarwin petebacondarwin changed the title r2 bindings (needs issue) r2 bindings Feb 1, 2022
@petebacondarwin petebacondarwin added this to the Wrangler 2.1 milestone Feb 1, 2022
@Electroid Electroid modified the milestones: 2.1, 2.0 Feb 3, 2022
@Electroid Electroid moved this to Blocking in workers-sdk Feb 7, 2022
@petebacondarwin petebacondarwin moved this from Must-have to In Progress in workers-sdk Feb 9, 2022
@petebacondarwin petebacondarwin mentioned this issue Feb 9, 2022
Merged
@petebacondarwin petebacondarwin moved this from In Progress to In Review in workers-sdk Feb 9, 2022
@petebacondarwin petebacondarwin moved this from In Review to In Progress in workers-sdk Feb 10, 2022
@petebacondarwin petebacondarwin changed the title r2 bindings r2 bucket support Feb 12, 2022
petebacondarwin added a commit that referenced this issue Feb 12, 2022
@petebacondarwin
feat: add support for publishing workers with r2 bucket bindings
f11b056 
This change adds the ability to define bindings in your `wrangler.toml` file
for R2 buckets. These buckets will then be available in the environment
passed to the worker at runtime.

Closes #365
@petebacondarwin petebacondarwin mentioned this issue Feb 12, 2022
Merged
@petebacondarwin petebacondarwin moved this from In Progress to In Review in workers-sdk Feb 12, 2022
petebacondarwin added a commit that referenced this issue Feb 13, 2022
@petebacondarwin
feat: add support for publishing workers with r2 bucket bindings
ab824ad 
This change adds the ability to define bindings in your `wrangler.toml` file
for R2 buckets. These buckets will then be available in the environment
passed to the worker at runtime.

Closes #365
petebacondarwin added a commit that referenced this issue Feb 13, 2022
@petebacondarwin
feat: add support for publishing workers with r2 bucket bindings (#452)
1cf6701 
* feat: add support for publishing workers with r2 bucket bindings

This change adds the ability to define bindings in your `wrangler.toml` file
for R2 buckets. These buckets will then be available in the environment
passed to the worker at runtime.

Closes #365
Repository owner moved this from In Review to Done in workers-sdk Feb 13, 2022
@github-actions github-actions bot mentioned this issue Feb 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petebacondarwin petebacondarwin

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@petebacondarwin @Electroid