-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: server proxy #205
Labels
enhancement
New feature or request
Comments
threepointone
added a commit
that referenced
this issue
Jan 11, 2022
Closes #205 This PR refactors how we setup the proxy server between the developer and the edge preview service during `wrangler dev`. Of note, we start the server immediately. We also buffers requests/streams and hold on to the, when starting/refreshing the token. This means a developer should never see `ERR_CONNECTION_REFUSED` error page, or have an older worker respond after making a change to the code. When the token does get refreshed, we flush said streams/requests with the newer values. -
threepointone
added a commit
that referenced
this issue
Jan 11, 2022
Closes #205 This PR refactors how we setup the proxy server between the developer and the edge preview service during `wrangler dev`. Of note, we start the server immediately. We also buffers requests/streams and hold on to the, when starting/refreshing the token. This means a developer should never see `ERR_CONNECTION_REFUSED` error page, or have an older worker respond after making a change to the code. When the token does get refreshed, we flush said streams/requests with the newer values.
threepointone
added a commit
that referenced
this issue
Jan 12, 2022
Closes #205 This PR refactors how we setup the proxy server between the developer and the edge preview service during `wrangler dev`. Of note, we start the server immediately. We also buffers requests/streams and hold on to the, when starting/refreshing the token. This means a developer should never see `ERR_CONNECTION_REFUSED` error page, or have an older worker respond after making a change to the code. When the token does get refreshed, we flush said streams/requests with the newer values.
threepointone
added a commit
that referenced
this issue
Jan 12, 2022
Closes #205 This PR refactors how we setup the proxy server between the developer and the edge preview service during `wrangler dev`. Of note, we start the server immediately. We also buffers requests/streams and hold on to the, when starting/refreshing the token. This means a developer should never see `ERR_CONNECTION_REFUSED` error page, or have an older worker respond after making a change to the code. When the token does get refreshed, we flush said streams/requests with the newer values.
threepointone
added a commit
that referenced
this issue
Jan 12, 2022
Closes #205 This PR refactors how we setup the proxy server between the developer and the edge preview service during `wrangler dev`. Of note, we start the server immediately. We also buffers requests/streams and hold on to the, when starting/refreshing the token. This means a developer should never see `ERR_CONNECTION_REFUSED` error page, or have an older worker respond after making a change to the code. When the token does get refreshed, we flush said streams/requests with the newer values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
During
wrangler dev
, we start a proxy server to act as an intermediary to the worker running on the edge. This proxy adds relevant headers, and acts as a stable URL during development, which is pretty good. There are some problems with our approach -ERR_CONNECTION_REFUSED
page in the browser (i.e - the server doesn't 'exist')ERR_CONNECTION_REFUSED
page again.We should fix this before GA. I'll get to it at the end if no one else does, but I'm happy to help anyone who'd like to take a crack at it.
The text was updated successfully, but these errors were encountered: