Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: wrangler publish --dry-run fetches migrations for durable objects #1038

Closed
threepointone opened this issue May 17, 2022 · 0 comments · Fixed by #1039 or #1025
Closed

bug: wrangler publish --dry-run fetches migrations for durable objects #1038

threepointone opened this issue May 17, 2022 · 0 comments · Fixed by #1039 or #1025
Assignees
@threepointone
Labels
bug Something that isn't working

Comments

@threepointone
Copy link
Contributor

This is bad because we don't want any network calls when --dry-run is true.
@threepointone threepointone added the bug Something that isn't working label May 17, 2022
@threepointone threepointone self-assigned this May 17, 2022
@threepointone threepointone moved this to Untriaged in workers-sdk May 17, 2022
@threepointone threepointone moved this from Untriaged to In Progress in workers-sdk May 17, 2022
threepointone added a commit that referenced this issue May 17, 2022
@threepointone
fix: don't fetch migrations when in --dry-run mode
e4c0c42 
Fixes #1038
@threepointone threepointone mentioned this issue May 17, 2022
Merged
threepointone added a commit that referenced this issue May 17, 2022
@threepointone
fix: don't fetch migrations when in --dry-run mode (#1039)
95852c3 
Fixes #1038
Repository owner moved this from In Progress to Done in workers-sdk May 17, 2022
@github-actions github-actions bot mentioned this issue May 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@threepointone threepointone

Labels
bug Something that isn't working
Projects
None yet
Milestone
No milestone
1 participant
@threepointone