bug: leading */*/. in routes causes bugs in wrangler dev
#1002
Assignees
Labels
bug
Something that isn't working
Comments
threepointone
added a commit
that referenced
this issue
May 16, 2022
When given routes, we use the host name from the route to deduce a zone id to pass along with the host to set with dev `session`. Route patterns can include leading `*`/`*.`, which we don't account for when deducing said zone id, resulting in subtle errors for the session. This fix strips those leading characters as appropriate. Fixes #1002
threepointone
added a commit
that referenced
this issue
May 16, 2022
When given routes, we use the host name from the route to deduce a zone id to pass along with the host to set with dev `session`. Route patterns can include leading `*`/`*.`, which we don't account for when deducing said zone id, resulting in subtle errors for the session. This fix strips those leading characters as appropriate. Fixes #1002
threepointone
added a commit
that referenced
this issue
May 16, 2022
When given routes, we use the host name from the route to deduce a zone id to pass along with the host to set with dev `session`. Route patterns can include leading `*`/`*.`, which we don't account for when deducing said zone id, resulting in subtle errors for the session. This fix strips those leading characters as appropriate. Fixes #1002
threepointone
added a commit
that referenced
this issue
May 16, 2022
When given routes, we use the host name from the route to deduce a zone id to pass along with the host to set with dev `session`. Route patterns can include leading `*`/`*.`, which we don't account for when deducing said zone id, resulting in subtle errors for the session. This fix strips those leading characters as appropriate. Fixes #1002
threepointone
added a commit
that referenced
this issue
May 16, 2022
When given routes, we use the host name from the route to deduce a zone id to pass along with the host to set with dev `session`. Route patterns can include leading `*`/`*.`, which we don't account for when deducing said zone id, resulting in subtle errors for the session. This fix strips those leading characters as appropriate. Fixes #1002
threepointone
added a commit
that referenced
this issue
May 16, 2022
#1018) When given routes, we use the host name from the route to deduce a zone id to pass along with the host to set with dev `session`. Route patterns can include leading `*`/`*.`, which we don't account for when deducing said zone id, resulting in subtle errors for the session. This fix strips those leading characters as appropriate. Fixes #1002
Repository owner
moved this from In Review
to Done
in workers-sdk
May 16, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using a route like
*foo.comor*.foo.comwith wrangler dev, zone id deduction fails, leading to subtle errors.The text was updated successfully, but these errors were encountered: