Skip to content

Commit

Permalink
changeset + casing
Browse files Browse the repository at this point in the history
  • Loading branch information
emily-shen committed Oct 31, 2024
1 parent 0378267 commit eb68f6f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/eleven-cobras-repeat.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"wrangler": patch
---

fix: throw a better error if there is an "ASSETS" user binding in a Pages projects
2 changes: 1 addition & 1 deletion packages/wrangler/src/config/validation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2773,7 +2773,7 @@ const validateBindingsHaveUniqueNames = (
bindingsGroupedByName[bindingName] = [];
}

if (bindingName === "ASSETS" && isPagesConfig(config)) {
if (bindingName.toUpperCase() === "ASSETS" && isPagesConfig(config)) {
diagnostics.errors.push(
`The name 'ASSETS' is reserved in Pages projects. Please use a different name for your ${bindingType} binding.`
);
Expand Down

0 comments on commit eb68f6f

Please sign in to comment.