fix: improve the error message for bad kv:namespace delete commands

Also adds more tests for this command.

.changeset/fluffy-oranges-press.md

@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+Improve the error message for bad `kv:namespace delete` commands

packages/wrangler/src/__tests__/kv.test.ts

@@ -202,25 +202,105 @@ describe("wrangler", () => {
     });
 
     describe("delete", () => {
-      it("should delete a namespace", async () => {
-        let accountId = "";
-        let namespaceId = "";
+      function mockDeleteRequest(expectedNamespaceId: string) {
+        const requests = { count: 0 };
         setMock(
           "/accounts/:accountId/storage/kv/namespaces/:namespaceId",
-          (uri, init) => {
-            accountId = uri[1];
-            namespaceId = uri[2];
-            expect(uri[0]).toEqual(
-              "/accounts/some-account-id/storage/kv/namespaces/some-namespace-id"
-            );
-            expect(init.method).toBe("DELETE");
+          "DELETE",
+          ([_url, accountId, namespaceId]) => {
+            requests.count++;
+            expect(accountId).toEqual("some-account-id");
+            expect(namespaceId).toEqual(expectedNamespaceId);
+            return null;
           }
         );
+        return requests;
+      }
+
+      function writeWranglerConfig() {
+        writeFileSync(
+          "./wrangler.toml",
+          [
+            'name = "otherWorker"',
+            "kv_namespaces = [",
+            '  { binding = "someBinding", id = "bound-id", preview_id = "preview-bound-id" }',
+            "]",
+            "",
+            "[env.some-environment]",
+            "kv_namespaces = [",
+            '  { binding = "someBinding", id = "env-bound-id", preview_id = "preview-env-bound-id" }',
+            "]",
+          ].join("\n"),
+          "utf-8"
+        );
+      }
+
+      it("should delete a namespace specified by id", async () => {
+        const requests = mockDeleteRequest("some-namespace-id");
         await runWrangler(
           `kv:namespace delete --namespace-id some-namespace-id`
         );
-        expect(accountId).toEqual("some-account-id");
-        expect(namespaceId).toEqual("some-namespace-id");
+        expect(requests.count).toEqual(1);
+      });
+
+      it("should delete a namespace specified by binding name", async () => {
+        writeWranglerConfig();
+        const requests = mockDeleteRequest("bound-id");
+        await runWrangler(`kv:namespace delete --binding someBinding`);
+        expect(requests.count).toEqual(1);
+      });
+
+      it("should delete a preview namespace specified by binding name", async () => {
+        writeWranglerConfig();
+        const requests = mockDeleteRequest("preview-bound-id");
+        await runWrangler(
+          `kv:namespace delete --binding someBinding --preview`
+        );
+        expect(requests.count).toEqual(1);
+      });
+
+      it("should error if a given binding name is not in the configured kv namespaces", async () => {
+        writeWranglerConfig();
+        const { stderr } = await runWrangler(
+          `kv:namespace delete --binding otherBinding`
+        );
+        expect(stderr).toMatchInlineSnapshot(`
+          "wrangler kv:namespace delete
+
+          Deletes a given namespace.
+
+          Flags:
+            -c, --config   Path to .toml configuration file  [string]
+            -h, --help     Show help  [boolean]
+            -v, --version  Show version number  [boolean]
+
+          Options:
+            -l, --local         Run on my machine  [boolean] [default: false]
+                --binding       The name of the namespace to delete  [string]
+                --namespace-id  The id of the namespace to delete  [string]
+                --env           Perform on a specific environment  [string]
+                --preview       Interact with a preview namespace  [boolean]
+          Not able to delete namespace.
+          A namespace with binding name \\"otherBinding\\" was not found in the configured \\"kv_namespaces\\"."
+        `);
+      });
+
+      it("should delete a namespace specified by binding name in a given environment", async () => {
+        writeWranglerConfig();
+        const requests = mockDeleteRequest("env-bound-id");
+        await runWrangler(
+          `kv:namespace delete --binding someBinding --env some-environment`
+        );
+        expect(requests.count).toEqual(1);
+      });
+
+      it("should delete a preview namespace specified by binding name in a given environment", async () => {
+        writeWranglerConfig();
+        const requests = mockDeleteRequest("preview-env-bound-id");
+        await runWrangler(
+          `kv:namespace delete --binding someBinding --env some-environment --preview`
+        );
+        expect(requests.count).toEqual(1);
       });
     });
   });

packages/wrangler/src/index.tsx

@@ -1211,6 +1211,8 @@ export async function main(argv: string[]): Promise<void> {
             console.log(
               `{ binding = "${args.namespace}", ${previewString}id = "${namespaceId}" }`
             );
+
+            // TODO: automatically write this block to the wrangler.toml config file??
           }
         )
         .command(
@@ -1293,9 +1295,12 @@ export async function main(argv: string[]): Promise<void> {
                 : config
               ).kv_namespaces.find(
                 (namespace) => namespace.binding === args.binding
-              )[args.preview ? "preview_id" : "id"];
+              )?.[args.preview ? "preview_id" : "id"];
             if (!id) {
-              throw new Error("Are you sure? id not found");
+              throw (
+                "Not able to delete namespace.\n" +
+                `A namespace with binding name "${args.binding}" was not found in the configured "kv_namespaces".`
+              );
             }
 
             // -- snip, extract --