fix: add better error for user binding called ASSETS in pages projects (

#7141)

* add better error for user binding called ASSETS in pages projects

* changeset + casing

* remove case insensitivity

.changeset/eleven-cobras-repeat.md

@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+fix: throw a better error if there is an "ASSETS" user binding in a Pages projects

packages/wrangler/src/__tests__/configuration.pages.test.ts

@@ -767,5 +767,47 @@ describe("normalizeAndValidateConfig()", () => {
 				);
 			});
 		});
+
+		it("should error if there is a user binding named ASSETS at the top-level", () => {
+			const { diagnostics } = normalizeAndValidateConfig(
+				{
+					...pagesRawConfig,
+					kv_namespaces: [
+						{
+							binding: "ASSETS",
+							id: "1234",
+						},
+					],
+				},
+				undefined,
+				{ env: undefined }
+			);
+
+			expect(diagnostics.errors).toEqual([
+				"The name 'ASSETS' is reserved in Pages projects. Please use a different name for your KV Namespaces binding.",
+			]);
+		});
+
+		it("should error if there is a user binding named ASSETS in a named environment", () => {
+			const { diagnostics } = normalizeAndValidateConfig(
+				{
+					...pagesRawConfig,
+					env: {
+						preview: {
+							...pagesRawConfig.env?.preview,
+							vars: { ASSETS: "test_value" },
+						},
+					},
+				},
+				undefined,
+				{
+					env: "preview",
+				}
+			);
+
+			expect(diagnostics.errors).toEqual([
+				"The name 'ASSETS' is reserved in Pages projects. Please use a different name for your Vars binding.",
+			]);
+		});
 	});
 });

packages/wrangler/src/config/validation.ts

@@ -2773,6 +2773,12 @@ const validateBindingsHaveUniqueNames = (
 				bindingsGroupedByName[bindingName] = [];
 			}
 
+			if (bindingName === "ASSETS" && isPagesConfig(config)) {
+				diagnostics.errors.push(
+					`The name 'ASSETS' is reserved in Pages projects. Please use a different name for your ${bindingType} binding.`
+				);
+			}
+
 			bindingsGroupedByName[bindingName].push(bindingType);
 		}
 	}