Fix proxy request typing bug and fallback 404 behavior in pages (#114)

* Fix typing bug * Add fallback 404 behavior
cloudflare · Dec 15, 2021 · c7bee70 · c7bee70
1 parent e928f94
commit c7bee70
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/.changeset/long-ligers-study.md b/.changeset/long-ligers-study.md
@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+Patches typing mismatches between us, undici and miniflare when proxying requests in pages dev, and also adds fallback 404 behavior which was missed
diff --git a/packages/wrangler/src/pages.tsx b/packages/wrangler/src/pages.tsx
@@ -474,6 +474,9 @@ const generateAssetsFetch = async (
         deconstructedResponse.body = serveAsset(asset);
         return deconstructedResponse;
       }
+
+      deconstructedResponse.status = 404;
+      return deconstructedResponse;
     };
 
     let asset;
@@ -787,7 +790,7 @@ export const pages: BuilderCallback<unknown, unknown> = (yargs) => {
                   const url = new URL(request.url);
                   url.host = `127.0.0.1:${proxyPort}`;
                   request = new Request(url.toString(), request);
-                  return await fetch(request);
+                  return await fetch(request.url, request);
                 } catch (thrown) {
                   console.error(`Could not proxy request: ${thrown}`);