Revert "add support for assets bindings to getPlatformProxy (#7816)" (

#7866) This reverts commit f6cc029.
cloudflare · Jan 22, 2025 · c3c193e · c3c193e
1 parent a2f695b
commit c3c193e
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 33 deletions.
diff --git a/fixtures/get-platform-proxy/public/test.txt b/fixtures/get-platform-proxy/public/test.txt
diff --git a/fixtures/get-platform-proxy/tests/get-platform-proxy.env.test.ts b/fixtures/get-platform-proxy/tests/get-platform-proxy.env.test.ts
@@ -2,11 +2,7 @@ import path from "path";
 import { D1Database, R2Bucket } from "@cloudflare/workers-types";
 import { beforeEach, describe, expect, it, vi } from "vitest";
 import { getPlatformProxy } from "./shared";
-import type {
-	Fetcher,
-	Hyperdrive,
-	KVNamespace,
-} from "@cloudflare/workers-types";
+import type { Hyperdrive, KVNamespace } from "@cloudflare/workers-types";
 import type { Unstable_DevWorker } from "wrangler";
 
 type Env = {
@@ -19,7 +15,6 @@ type Env = {
 	MY_BUCKET: R2Bucket;
 	MY_D1: D1Database;
 	MY_HYPERDRIVE: Hyperdrive;
-	ASSETS: Fetcher;
 };
 
 const wranglerTomlFilePath = path.join(__dirname, "..", "wrangler.toml");
@@ -120,17 +115,6 @@ describe("getPlatformProxy - env", () => {
 		}
 	});
 
-	it("correctly obtains functioning ASSETS bindings", async () => {
-		const { env, dispose } = await getPlatformProxy<Env>({
-			configPath: wranglerTomlFilePath,
-		});
-		const { ASSETS } = env;
-		const res = await ASSETS.fetch("https://0.0.0.0/test.txt");
-		const text = await res.text();
-		expect(text).toEqual("this is a test text file!\n");
-		await dispose();
-	});
-
 	it("correctly obtains functioning KV bindings", async () => {
 		const { env, dispose } = await getPlatformProxy<Env>({
 			configPath: wranglerTomlFilePath,

diff --git a/fixtures/get-platform-proxy/wrangler.toml b/fixtures/get-platform-proxy/wrangler.toml
@@ -7,12 +7,6 @@ MY_VAR = "my-var-value"
 MY_VAR_A = "my-var-a"
 MY_JSON_VAR = { test = true }
 
-[assets]
-directory = "./public"
-binding = "ASSETS"
-html_handling = "auto-trailing-slash"
-not_found_handling = "none"
-
 [[kv_namespaces]]
 binding = "MY_KV"
 id = "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"

diff --git a/packages/wrangler/src/api/integrations/platform/index.ts b/packages/wrangler/src/api/integrations/platform/index.ts
@@ -158,14 +158,6 @@ async function getMiniflareOptionsFromConfig(
 		migrations: rawConfig.migrations,
 	});
 
-	const processedAssetOptions = getAssetsOptions(
-		{ assets: undefined },
-		rawConfig
-	);
-	const assetOptions = processedAssetOptions
-		? buildAssetOptions({ assets: processedAssetOptions })
-		: {};
-
 	const persistOptions = getMiniflarePersistOptions(options.persist);
 
 	const serviceBindings = await getServiceBindings(bindings.services);
@@ -180,7 +172,6 @@ async function getMiniflareOptionsFromConfig(
 					...serviceBindings,
 					...bindingOptions.serviceBindings,
 				},
-				...assetOptions,
 			},
 			...externalWorkers,
 		],