fix: normalise account_id = '' to account_id: undefined (#1365)

In older templates, (i.e made for wrangler 1.x), `account_id =''` is considered as a valid input, but then ignored. With wrangler 2, when running wrangler dev, we log an error, but it fixes itself after we get an account id. Much like #1329, the fix here is to normalise that value when we see it, and replace it with `undefined` while logging a warning. This fix also tweaks the messaging for a blank route value to suggest some user action.
cloudflare · Jun 28, 2022 · b9f7200 · b9f7200
1 parent d2b1142
commit b9f7200
Show file tree

Hide file tree

Showing 4 changed files with 2,291 additions and 2,218 deletions.
diff --git a/.changeset/slow-pianos-impress.md b/.changeset/slow-pianos-impress.md
@@ -0,0 +1,9 @@
+---
+"wrangler": patch
+---
+
+fix: normalise `account_id = ''` to `account_id: undefined`
+
+In older templates, (i.e made for wrangler 1.x), `account_id =''` is considered as a valid input, but then ignored. With wrangler 2, when running wrangler dev, we log an error, but it fixes itself after we get an account id. Much like https://github.com/cloudflare/wrangler2/issues/1329, the fix here is to normalise that value when we see it, and replace it with `undefined` while logging a warning.
+
+This fix also tweaks the messaging for a blank route value to suggest some user action.