Skip to content

Commit

Permalink
fix: Windows symlinks are lost during caching, resolution is always r…
Browse files Browse the repository at this point in the history
…unning `npm ci` for Windows GitHub Workflows (#1032)
  • Loading branch information
JacobMGEvans authored May 16, 2022
1 parent 5816eba commit a6e2057
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/create-pullrequest-prerelease.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}

- name: Install NPM Dependencies
if: steps.node-modules-cache.outputs.cache-hit != 'true'
if: steps.node-modules-cache.outputs.cache-hit != 'true' || runner.os == 'Windows'
run: npm ci

- name: Modify package.json version
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/prereleases.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}

- name: Install NPM Dependencies
if: steps.node-modules-cache.outputs.cache-hit != 'true'
if: steps.node-modules-cache.outputs.cache-hit != 'true' || runner.os == 'Windows'
run: npm ci

- name: Modify package.json version
Expand Down Expand Up @@ -77,7 +77,7 @@ jobs:
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}

- name: Install NPM Dependencies
if: steps.node-modules-cache.outputs.cache-hit != 'true'
if: steps.node-modules-cache.outputs.cache-hit != 'true' || runner.os == 'Windows'
run: npm ci

- name: Build wrangler
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pullrequests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
${{ runner.os }}-node-
- name: Install NPM Dependencies
if: steps.node-modules-cache.outputs.cache-hit != 'true'
if: steps.node-modules-cache.outputs.cache-hit != 'true' || runner.os == 'Windows'
run: npm ci

- name: Check for errors
Expand Down Expand Up @@ -82,7 +82,7 @@ jobs:
${{ runner.os }}-node-
- name: Install NPM Dependencies
if: steps.node-modules-cache.outputs.cache-hit != 'true'
if: steps.node-modules-cache.outputs.cache-hit != 'true' || runner.os == 'Windows'
run: npm ci

- name: Run builds
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
${{ runner.os }}-node-
- name: Install NPM Dependencies
if: steps.node-modules-cache.outputs.cache-hit != 'true'
if: steps.node-modules-cache.outputs.cache-hit != 'true' || runner.os == 'Windows'
run: npm ci

- name: Check for errors
Expand Down

0 comments on commit a6e2057

Please sign in to comment.