Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Greg Brimble <[email protected]>
  • Loading branch information
taylorlee and GregBrimble authored Oct 24, 2024
1 parent 650dfd7 commit 1dfe8b0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .changeset/chilled-apes-repeat.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
"wrangler": patch
---

fix: synchronize observability settings during versions deploy
fix: synchronize observability settings during `wrangler versions deploy`

When running `wrangler versions deploy`, wrangler will now update observability settings in addition to logpush and `tail_consumers`. Unlike `wrangler deploy`, it will not disable observability when observability is undefined in wrangler.toml
When running `wrangler versions deploy`, Wrangler will now update `observability` settings in addition to `logpush` and `tail_consumers`. Unlike `wrangler deploy`, it will not disable observability when `observability` is undefined in `wrangler.toml`.
2 changes: 1 addition & 1 deletion packages/wrangler/src/versions/deploy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,7 @@ async function maybePatchSettings(
},
});

let observability = [];
const observability = [];
if (patchedSettings.observability) {
observability.push(`enabled: ${patchedSettings.observability.enabled}`);
if (patchedSettings.observability.head_sampling_rate) {
Expand Down

0 comments on commit 1dfe8b0

Please sign in to comment.