enable @typescript-eslint/no-floating-promises, pass lint+type check (

#121)

* enable @typescript-eslint/no-floating-promises, pass lint+type check

Enabling that lint rule exposed a bunch of places where we weren't logging errors, and also caught at least 3 bugs. Glad I did this.

I also disabled prettier as an eslint error,  and added it to the `check` script instead.

I added `ioredis` as a root dependency. We don't use it, but we can't pass typecheck without it installed (because miniflare uses it, even tho it's an optional dep, and there's no good way to disable a third party's type errors in this fashion)

I also added `react-error-boundary` so we don't blow up completely, and have an option to handle errors from `dev` gracefully.

* add a changeset

* apply review suggestions

.changeset/strong-penguins-report.md

@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+enable @typescript-eslint/no-floating-promises, pass lint+type check

.github/workflows/tests-typecheck.yml

@@ -48,13 +48,11 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-node-
 
-        # Prefer offline will skip registry verification with cached NPM packages
       - name: Install NPM dependencies
         run: npm install
 
       - name: Run Type Checking & ESLint
-        #TODO remove the --skipLibCheck flag at some point
-        run: tsc --skipLibCheck && npm run lint
+        run: npm run check
 
       - name: Test
         run: npm run test

package.json

@@ -23,14 +23,15 @@
     "eslint-plugin-prettier": "^4.0.0",
     "eslint-plugin-react": "^7.27.1",
     "eslint-plugin-react-hooks": "^4.3.0",
+    "ioredis": "^4.28.2",
     "jest": "^27.4.2",
     "prettier": "^2.5.1",
     "source-map-explorer": "^2.5.2",
     "typescript": "^4.5.2"
   },
   "scripts": {
     "lint": "eslint packages/**",
-    "check": "tsc && npm run lint",
+    "check": "prettier packages/** --check && tsc && npm run lint",
     "prettify": "prettier packages/** --write"
   },
   "engines": {
@@ -42,6 +43,13 @@
       "packages/wrangler/vendor"
     ],
     "parser": "@typescript-eslint/parser",
+    "parserOptions": {
+      "ecmaVersion": 2020,
+      "project": [
+        "tsconfig.json"
+      ],
+      "sourceType": "module"
+    },
     "plugins": [
       "@typescript-eslint",
       "eslint-plugin-react",
@@ -66,10 +74,10 @@
           "plugin:react-hooks/recommended"
         ],
         "rules": {
-          "prettier/prettier": "error",
           "@typescript-eslint/consistent-type-imports": [
             "error"
           ],
+          "@typescript-eslint/no-floating-promises": "error",
           "no-empty": "off",
           "require-yield": "off",
           "no-empty-function": "off",

packages/wrangler/package.json

@@ -73,7 +73,8 @@
     "tmp-promise": "^3.0.3",
     "undici": "^4.11.1",
     "ws": "^8.3.0",
-    "yargs": "^17.3.0"
+    "yargs": "^17.3.0",
+    "react-error-boundary": "^3.1.4"
   },
   "files": [
     "src",

packages/wrangler/scripts/bundle.ts

@@ -21,4 +21,7 @@ async function run() {
   });
 }
 
-run();
+run().catch((e) => {
+  console.error(e);
+  process.exit(1);
+});

packages/wrangler/src/api/inspect.ts

@@ -140,17 +140,6 @@ export type DtEvent = DtLogEvent | DtExceptionEvent;
  */
 export type DtListener = (event: DtEvent) => void;
 
-interface DtProtocolRequest<T> {
-  id: number;
-  method: string;
-  params?: T;
-}
-
-interface DtProtocolResponse<T> {
-  id: number;
-  result: T;
-}
-
 /**
  * A DevTools inspector that listens to logs and debug events from a Worker.
  *