Skip to content

Commit

Permalink
Version Packages (#944)
Browse files Browse the repository at this point in the history
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
  • Loading branch information
github-actions[bot] and github-actions[bot] authored May 10, 2022
1 parent 38b7242 commit 1a7a7f1
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 18 deletions.
5 changes: 0 additions & 5 deletions .changeset/chatty-wolves-bathe.md

This file was deleted.

11 changes: 0 additions & 11 deletions .changeset/good-geese-matter.md

This file was deleted.

2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 14 additions & 0 deletions packages/wrangler/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,19 @@
# wrangler

## 2.0.2

### Patch Changes

- [#947](https://github.com/cloudflare/wrangler2/pull/947) [`38b7242`](https://github.com/cloudflare/wrangler2/commit/38b7242621eb26fef9910ce4a161d26baff08d0a) Thanks [@GregBrimble](https://github.com/GregBrimble)! - Updated defaults and help of wrangler pages publish

* [#941](https://github.com/cloudflare/wrangler2/pull/941) [`d84b568`](https://github.com/cloudflare/wrangler2/commit/d84b568818cf1ec4654aec806b27c40681df9c7b) Thanks [@threepointone](https://github.com/threepointone)! - fix: bundle worker as iife if detected as a service worker

We detect whether a worker is a "modules" format worker by the presence of a `default` export. This is a pretty good heuristic overall, but sometimes folks can make mistakes. One situation that's popped up a few times, is people writing exports, but still writing it in "service worker" format. We detect this fine, and log a warning about the exports, but send it up with the exports included. Unfortunately, our runtime throws when we mark a worker as a service worker, but still has exports. This patch fixes it so that the exports are not included in a service-worker worker.

Note that if you're missing an event listener, it'll still error with "No event handlers were registered. This script does nothing." but that's a better error than the SyntaxError _even when the listener was there_.

Fixes https://github.com/cloudflare/wrangler2/issues/937

## 2.0.1

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/wrangler/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "wrangler",
"version": "2.0.1",
"version": "2.0.2",
"author": "[email protected]",
"description": "Command-line interface for all things Cloudflare Workers",
"bin": {
Expand Down

0 comments on commit 1a7a7f1

Please sign in to comment.