chore: setup the workflows to cache (#977)

* chore: setup the workflows to cache Added caching of `node_modules` when nothing has changed in any `package.json` also using the `setup-node` built-in cache of `~/.npm` which will speed up `npm ci` when it has to run * Added `restore-keys` for direct reference to cached resources per runner
cloudflare · May 15, 2022 · 02a2cae · 02a2cae
1 parent 9906e1c
commit 02a2cae
Show file tree

Hide file tree

Showing 5 changed files with 50 additions and 12 deletions.
diff --git a/.github/workflows/create-pullrequest-prerelease.yml b/.github/workflows/create-pullrequest-prerelease.yml
@@ -18,7 +18,7 @@ jobs:
         uses: actions/setup-node@v3
         with:
           node-version: 16.7
-          cache: "npm"
+          cache: "npm" # cache ~/.npm in case 'npm ci' needs to run
 
       - uses: actions/cache@v3
         id: node-modules-cache
@@ -29,7 +29,8 @@ jobs:
           key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
 
       - name: Install NPM Dependencies
-        run: npm install
+        if: steps.node-modules-cache.outputs.cache-hit != 'true'
+        run: npm ci
 
       - name: Modify package.json version
         run: node .github/version-script.js

diff --git a/.github/workflows/experimental-wasm-release.yml b/.github/workflows/experimental-wasm-release.yml
@@ -19,7 +19,17 @@ jobs:
         uses: actions/setup-node@v3
         with:
           node-version: 16.7
-          cache: "npm"
+          cache: "npm" # cache ~/.npm in case 'npm ci' needs to run
+
+      - uses: actions/cache@v3
+        id: node-modules-cache
+        with:
+          path: |
+            node_modules
+            */*/node_modules
+          key: ${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}
+          restore-keys: |
+            ${{ runner.os }}-node-
 
       - name: Install NPM Dependencies
         run: npm ci

diff --git a/.github/workflows/prereleases.yml b/.github/workflows/prereleases.yml
@@ -20,7 +20,7 @@ jobs:
         uses: actions/setup-node@v3
         with:
           node-version: 16.7
-          cache: "npm"
+          cache: "npm" # cache ~/.npm in case 'npm ci' needs to run
 
       - uses: actions/cache@v3
         id: node-modules-cache
@@ -31,7 +31,8 @@ jobs:
           key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
 
       - name: Install NPM Dependencies
-        run: npm install
+        if: steps.node-modules-cache.outputs.cache-hit != 'true'
+        run: npm ci
 
       - name: Modify package.json version
         run: node .github/version-script.js
@@ -65,7 +66,7 @@ jobs:
         uses: actions/setup-node@v3
         with:
           node-version: 16.7
-          cache: "npm"
+          cache: "npm" # cache ~/.npm in case 'npm ci' needs to run
 
       - uses: actions/cache@v3
         id: node-modules-cache
@@ -76,7 +77,8 @@ jobs:
           key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
 
       - name: Install NPM Dependencies
-        run: npm install
+        if: steps.node-modules-cache.outputs.cache-hit != 'true'
+        run: npm ci
 
       - name: Build wrangler
         run: npm run build

diff --git a/.github/workflows/pullrequests.yml b/.github/workflows/pullrequests.yml
@@ -19,7 +19,7 @@ jobs:
         uses: actions/setup-node@v3
         with:
           node-version: 16.7
-          cache: "npm"
+          cache: "npm" # cache ~/.npm in case 'npm ci' needs to run
 
       - uses: actions/cache@v3
         id: eslint-cache
@@ -29,7 +29,18 @@ jobs:
             tsconfig.tsbuildinfo
           key: ${{ matrix.os }}-eslint-tsbuildinfo-${{ hashFiles('**/*.ts','**/*.js', 'package.json', 'tsconfig.json') }}
 
+      - uses: actions/cache@v3
+        id: node-modules-cache
+        with:
+          path: |
+            node_modules
+            */*/node_modules
+          key: ${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}
+          restore-keys: |
+            ${{ runner.os }}-node-
+
       - name: Install NPM Dependencies
+        if: steps.node-modules-cache.outputs.cache-hit != 'true'
         run: npm ci
 
       - name: Check for errors
@@ -51,7 +62,7 @@ jobs:
         uses: actions/setup-node@v3
         with:
           node-version: 16.7
-          cache: "npm"
+          cache: "npm" # cache ~/.npm in case 'npm ci' needs to run
 
       - name: Restore Wrangler 1 from Cache
         uses: actions/cache@v3
@@ -60,7 +71,18 @@ jobs:
           path: packages/wranglerjs-compat-webpack-plugin/src/__tests__/helpers/.wrangler-1-cache
           key: ${{ matrix.os }}-wrangler-1-cache
 
+      - uses: actions/cache@v3
+        id: node-modules-cache
+        with:
+          path: |
+            node_modules
+            */*/node_modules
+          key: ${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}
+          restore-keys: |
+            ${{ runner.os }}-node-
+
       - name: Install NPM Dependencies
+        if: steps.node-modules-cache.outputs.cache-hit != 'true'
         run: npm ci
 
       - name: Run builds

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -20,18 +20,21 @@ jobs:
         uses: actions/setup-node@v3
         with:
           node-version: 16.7
-          cache: "npm"
+          cache: "npm" # cache ~/.npm in case 'npm ci' needs to run
 
       - uses: actions/cache@v3
         id: node-modules-cache
         with:
           path: |
             node_modules
             */*/node_modules
-          key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
+          key: ${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}
+          restore-keys: |
+            ${{ runner.os }}-node-
 
       - name: Install NPM Dependencies
-        run: npm install
+        if: steps.node-modules-cache.outputs.cache-hit != 'true'
+        run: npm ci
 
       - name: Check for errors
         run: npm run check