properly handle errors on compile cache generation #5309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
reviewed
Oct 15, 2025
jasnell
reviewed
Oct 15, 2025
anonrig
force-pushed
the
yagiz/improve-errors
branch
from
a3a845d to
97fe065
Compare
anonrig
force-pushed
the
yagiz/improve-errors
branch
from
97fe065 to
f35d345
Compare
Collaborator
|
Possible to add a test? |
Member
Author
It's extremely hard. You need to compile workerd with an error on the global scope of the file on a non-typescript file to reproduce this. |
jasnell
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from #5298