Allow setAlarm to be invoked in Durable Object constructors #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
reviewed
Feb 13, 2023
jasnell
approved these changes
Feb 13, 2023
For implementation reasons, we cannot confirm the presence of an alarm handler during the invocation of a durable object's constructor. That said, we also cannot confirm the absence of that handler either. Let's just lean on the alarm runner to do the right thing when the time comes.
bcaimano
force-pushed
the
bcaimano/alarm-in-ctor
branch
from
d23b142 to
edfecbb
Compare
a-robinson
approved these changes
Feb 13, 2023
xortive
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For implementation reasons, we cannot confirm the presence of an alarm handler during the invocation of a durable object's constructor. That said, we also cannot confirm the absence of that handler either. Let's just lean on the alarm runner to do the right thing when the time comes.