Fixup buggy URLSearchParams iterators #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrishancock
approved these changes
Feb 8, 2023
jasnell
commented
Feb 8, 2023
| return kj::arr(kj::str(key), kj::str(value)); | ||
| } else if constexpr (kj::isSameType<Type, KeyIteratorType>()) { | ||
| return kj::str(key); | ||
| } else if constexpr (kj::isSameType<Type, ValueIteratorType>()) { |
There was a problem hiding this comment.
@harrishancock ... the bug was here. KeyIteratorType and ValueIteratorType were the same type. doh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @harrishancock @mikea