Revert "Continue work on new module registry" #3401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit da66065.
|
Specifically, breaks internal fuzzing tests. Will investigate in the next day or two then try again. |
jasnell
approved these changes
Jan 23, 2025
|
Investigation is actually pointing to the internal fuzzer-asan issue is likely a false positive. The same error occurs with or without this change in various tests. It would suggest that the internal bazel build configuration is not being appropriately applied to workerd when testing such that parts of the code are instrumented and other parts are not. Still digging but that's the current hypothesis. I believe this PR just surfaced the issue in testing but did not actually introduce any actual bugs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaks things downstream, not sure why.
Reverts #3372