Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8 13.2 #3391

Merged
merged 3 commits into from
Jan 22, 2025
Merged

v8 13.2 #3391

merged 3 commits into from
Jan 22, 2025

Conversation

mikea
Copy link
Collaborator

@mikea mikea commented Jan 22, 2025

No description provided.

@mikea mikea requested a review from fhanau January 22, 2025 16:58
@mikea mikea requested review from a team as code owners January 22, 2025 16:58
@mikea mikea requested a review from hoodmane January 22, 2025 16:58
build/deps/v8.bzl Outdated Show resolved Hide resolved
@mikea mikea force-pushed the maizatskyi/2025-01-22-v8 branch 3 times, most recently from 94160aa to 2a178d9 Compare January 22, 2025 17:30
@mikea mikea enabled auto-merge (squash) January 22, 2025 17:35
@fhanau
Copy link
Collaborator

fhanau commented Jan 22, 2025

Changes themselves look good. Unfortunately, V8 reverted Erik's patch to add shared linkage support for V8 that landed in 13.1, so we'll have to bring back patches/v8/0008-Enable-V8-shared-linkage.patch from when we had 13.0 (shared linkage is only supported in Linux but helps keep binary sizes under control, especially relevant for asan and debug jobs which might experience disk space exhaustion otherwise).

@mikea mikea force-pushed the maizatskyi/2025-01-22-v8 branch from 2a178d9 to a74f1f0 Compare January 22, 2025 17:43
@mikea mikea requested a review from fhanau January 22, 2025 17:43
@mikea mikea merged commit deec614 into main Jan 22, 2025
17 checks passed
@mikea mikea deleted the maizatskyi/2025-01-22-v8 branch January 22, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants