Improve releasing by merging npm and release jobs. #3390
Merged
+133
−214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
reviewed
Jan 22, 2025
fhanau
reviewed
Jan 22, 2025
fhanau
approved these changes
Jan 22, 2025
anonrig
approved these changes
Jan 22, 2025
Merge npm.yml and npm-types.yml into the release workflow. This will remove the neccessity to run the npm and npm-types jobs manually.
danlapid
force-pushed
the
dlapid/improve_releasing
branch
from
f8bcc0f to
9c3b5c7
Compare
penalosa
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge npm.yml and npm-types.yml into the release workflow.
This will remove the necessity to run the npm and npm-types jobs manually.
There can be further work done to remove duplication of bazel setup inside of this file and with the _bazel.yml file.
That improvement does not need to block this PR as this PR does not make this problem any worse than it was before.
There are other similar improvements that can honestly be done in this file that I also punted from achieving in this PR.
The fact that this entire file runs only on release makes it really hard to iterate and I'd rather change as little as possible.