Add diagnostic logging to determine import assertion use #3389
+30
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specification for import assertions strongly recommends that embedders reject import attributes and types they do not understand/implement. This is because import attributes can alter the interpretation of a module and are considered to be part of the unique key for caching a module. Throwing an error for things we do not understand is the safest thing to do. However, historically we have not followed this guideline in the spec and it's not clear if enforcing that constraint would be breaking so let's first try to determine if anyone is making use of import assertions. If we're lucky, we won't receive any hits on this and we can start enforcing the rule without a compat flag.