Embeds Python package locks in the binary. #3379
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the package lock is embedded in the pyodide.capnp.bin file. This couples the package lock to the Python bundle that we load which isn't ideal.
We have two solutions that we can pursue to fix this:
We have decided to go for the second option for two reasons:
Lock files are not particularly big so embedding them in the binary shouldn't be a problem.