Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new subcommand to workerd for making a Python snapshot #3368

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

hoodmane
Copy link
Contributor

For now this only makes baseline snapshots but I'll extend it to make package snapshots when I need it.

@hoodmane hoodmane requested review from a team as code owners January 20, 2025 15:27
@hoodmane hoodmane requested review from erikcorry and fhanau January 20, 2025 15:27
@hoodmane hoodmane requested a review from dom96 January 20, 2025 15:28
@dom96
Copy link
Collaborator

dom96 commented Jan 20, 2025

We already have python-save-baseline-snapshot (

.addOption({"python-save-baseline-snapshot"}, [this]() {
) for this which I think is the same as what you're adding here, right?

Copy link
Collaborator

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh okay, you want a nicer command that doesn't require a config.

src/workerd/server/workerd.c++ Outdated Show resolved Hide resolved
@hoodmane hoodmane force-pushed the hoodmane/make-pyodide-snapshot branch from 63fc125 to cce388a Compare January 20, 2025 17:13
For now this only makes baseline snapshots but I'll extend it to make
package snapshots when I need it.
@hoodmane hoodmane force-pushed the hoodmane/make-pyodide-snapshot branch from cce388a to 37c3a50 Compare January 20, 2025 17:26
@hoodmane hoodmane merged commit 3b3f4f1 into main Jan 20, 2025
17 checks passed
@hoodmane hoodmane deleted the hoodmane/make-pyodide-snapshot branch January 20, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants