Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cap boto3 in release-python-runtime job #3344

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Cap boto3 in release-python-runtime job #3344

merged 1 commit into from
Jan 16, 2025

Conversation

hoodmane
Copy link
Contributor

No description provided.

@hoodmane hoodmane requested review from a team as code owners January 16, 2025 10:36
@hoodmane hoodmane requested review from ketanhwr and danlapid January 16, 2025 10:36
@hoodmane
Copy link
Contributor Author

Manually tested this and it indeed fixes the upload.
Before:
https://github.com/cloudflare/workerd/actions/runs/12806746913
After:
https://github.com/cloudflare/workerd/actions/runs/12807087876

R2 should probably add support for this header.

@hoodmane hoodmane merged commit e8b4f58 into main Jan 16, 2025
15 checks passed
@hoodmane hoodmane deleted the hoodmane/cap-boto3 branch January 16, 2025 10:48
@danlapid
Copy link
Collaborator

Manually tested this and it indeed fixes the upload. Before: cloudflare/workerd/actions/runs/12806746913 After: cloudflare/workerd/actions/runs/12807087876

R2 should probably add support for this header.

Yeah, this change caused an incident and R2 is working on a fix for this. If you're interested in helping out they are blocked on us to add crc32 support to DigestStream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants