Add Browser Rendering JS wrapped binding #3334
Merged
+176
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G4brym
force-pushed
the
add-brapi-binding
branch
7 times, most recently
from
907c834 to
8e093a9
Compare
jasnell
reviewed
Jan 14, 2025
jasnell
approved these changes
Jan 14, 2025
G4brym
force-pushed
the
add-brapi-binding
branch
from
8e093a9 to
b2ad485
Compare
jasnell
reviewed
Jan 14, 2025
G4brym
force-pushed
the
add-brapi-binding
branch
from
b2ad485 to
1737772
Compare
|
@G4brym Would you mind updating the pull-request description? |
G4brym
changed the title
G4brym
changed the title
Just updated the title and description, let me know if there's anything else for me to do 👍 |
anonrig
approved these changes
Jan 14, 2025
auto-merge was automatically disabled
January 14, 2025 22:21
Head branch was pushed to by a user without write access
G4brym
force-pushed
the
add-brapi-binding
branch
from
1737772 to
07d73be
Compare
|
Sorry the builds were failing with the previous compability date, pushing a fix disabled auto merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browser rendering team is migrating from a simple Fetcher binding into a JS wrapped binding.
This pull requests adds a very simple wrapped binding that only exposes the already existing
.fetch()method for existing worker.Follow up pr's will include adding custom methods to this new binding once it starts being used.