Removes usage of embedded PYODIDE_LOCK in C++ code. #3328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. After this change PYODIDE_LOCK remains in |
fhanau
approved these changes
Jan 13, 2025
|
Thank you for the review Felix! Yeah, that one actually shares the same name but isn't using the embedded lock anymore. |
hoodmane
reviewed
Jan 14, 2025
hoodmane
reviewed
Jan 14, 2025
hoodmane
approved these changes
Jan 14, 2025
dom96
force-pushed
the
dominik/remove-python-lock
branch
from
908d291 to
29612f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements download of python bundle when running
workerd pyodide-lock+ some other clean up to remove the use of the embedded PYODIDE_LOCK.Test Plan