Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix node:dns quotation marks on resolveTxt #3327

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Jan 13, 2025

I'm not adding tests because I don't want to spam Yahoo on every PR run, but the following test now pass:

    // https://github.com/cloudflare/workerd/issues/3325
    {
      const result = await dnsPromises.resolveTxt('s1024._domainkey.yahoo.com');
      deepStrictEqual(result, [
        [
          'k=rsa;  p=MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDrEee0Ri4Juz+QfiWYui/E9UGSXau/2P8LjnTD8V4Unn+2FAZVGE3kL23bzeoULYv4PeleB3gfmJiDJOKU3Ns5L4KJAUUHjFwDebt0NP+sBK0VKeTATL2Yr/S3bT/xhy+1xtj4RkdV7fVxTn56Lb4udUnwuxK4V5b5PdOKj/+XcwIDAQAB; n=A 1024 bit key;',
        ],
      ]);
    }

Fixes #3325

@anonrig anonrig requested a review from jasnell January 13, 2025 16:08
@anonrig anonrig requested review from a team as code owners January 13, 2025 16:08
@anonrig anonrig requested a review from ketanhwr January 13, 2025 16:08
@anonrig anonrig merged commit 213a256 into main Jan 13, 2025
15 checks passed
@anonrig anonrig deleted the yagiz/fix-node-dns-resolvetxt branch January 13, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report — Incorrect data returned from resolveTxt in node:dns
2 participants