Convert WPT test harness to TS #3324
Merged
+257
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npaun
commented
Jan 10, 2025
npaun
force-pushed
the
npaun/tsify-wpt-harness
branch
2 times, most recently
from
a9090c0 to
19f55a3
Compare
anonrig
reviewed
Jan 10, 2025
npaun
force-pushed
the
npaun/tsify-wpt-harness
branch
2 times, most recently
from
dbb12e1 to
83a76ce
Compare
|
@anonrig eslint issues should all be addressed now |
jasnell
approved these changes
Jan 13, 2025
anonrig
approved these changes
Jan 13, 2025
|
It seems there are some eslint errors |
|
They only happen in CI, not on my machine. Going to look into what's up with that and get rid of the errors. |
npaun
force-pushed
the
npaun/tsify-wpt-harness
branch
from
83a76ce to
96dd979
Compare
|
The error was caused by not passing "//:node_modules/@types/node" to the eslint_test rule. Fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts our WPT test harness to TypeScript.