Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove eslint-prettier-config #3320

Merged
merged 1 commit into from
Jan 10, 2025
Merged

remove eslint-prettier-config #3320

merged 1 commit into from
Jan 10, 2025

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Jan 10, 2025

Upon recommendation from @JoshuaKGoldberg (typescript-eslint/typescript-eslint#10635 (comment)), removing invalid typescript-eslint rule, and removing eslint-prettier-config because it takes too much time running eslint with prettier.

We already have a linter check using just f no need to do the same work twice.

PS: This decreases eslint test to 4.1s seconds from 8 on a 88 core machine.

Copy link
Collaborator

@danlapid danlapid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LBTM

@anonrig anonrig requested a review from fhanau January 10, 2025 16:26
@anonrig anonrig merged commit 5055345 into main Jan 10, 2025
15 checks passed
@anonrig anonrig deleted the remove-eslint-prettier branch January 10, 2025 16:29
Copy link

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, love to see the speedup! 🚀

@fhanau
Copy link
Collaborator

fhanau commented Jan 10, 2025

PS: This decreases eslint test to 4.1s seconds from 8 on a 88 core machine.

LGTM, but the @eslint job is single-threaded so the number of cores doesn't really matter right?

@anonrig
Copy link
Member Author

anonrig commented Jan 10, 2025

PS: This decreases eslint test to 4.1s seconds from 8 on a 88 core machine.

LGTM, but the @eslint job is single-threaded so the number of cores doesn't really matter right?

Yes, I was just showing the ridiculousness of the amount of time it takes to lint and format our JS files...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants