Save HibernatableWebSocketEventInfo events by value

[danlapid]

These events are so small...

  struct Message final {};
  struct Close final {
    uint16_t code;
    bool wasClean;
  };
  struct Error final {};

That there shouldn't even be any performance penalty to saving them by value rather than by reference.
The nice thing about it is we don't need to save bare references that can easily cause UB or worse (such as a bug we're trying hopelessly to debug atm).

[anonrig]

The nice thing about it is we don't need to save bare references that can easily cause UB or worse (such as a bug we're trying hopelessly to debug atm).

100 percent. I raise you and say: "not unless we use shared_ptr"

[danlapid]

The nice thing about it is we don't need to save bare references that can easily cause UB or worse (such as a bug we're trying hopelessly to debug atm).

100 percent. I raise you and say: "not unless we use shared_ptr"

Yeah shared ptr is great but for these structures specifically it’s probably cheaper to just copy them 😅

[anonrig]

Yeah shared ptr is great but for these structures specifically it’s probably cheaper to just copy them 😅

Or I can raise one more time and mention reference counting through kj. (I'm so happy to show off my KJ knowledge. Mom and dad are proud)