Add workerd:compatibility-flags internal built-in module #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
commented
Jan 28, 2023
kentonv
reviewed
Jan 28, 2023
|
Looks good but needs squash. (I'm paranoid about accidentally merging fixups after it has happened a couple times. FWIW given the "view changes" button it's OK to not push fixups but instead just force-push a rewrite, as long as you don't rebase on main in the same push.) |
jasnell
force-pushed
the
jsnell/internal-compatibilityflags-module
branch
from
751d2b4 to
5030acc
Compare
For use only by built-in TypeScript modules, this provides an import
that gives information on the currently set compatibility flags.
e.g.
```
import { default as flags } from 'worker:compatibility-flags';
console.log(flags.nodeJsCompat); // true|false
```
The flags are set as readonly booleans on the export.
jasnell
force-pushed
the
jsnell/internal-compatibilityflags-module
branch
from
5030acc to
fa00599
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For use only by built-in TypeScript modules, this provides an import that gives information on the currently set compatibility flags.
e.g.
The flags are set as readonly booleans on the export.
Note that this does introduce an issue if we rename any of the compatibility flags. Right now renaming will cause a compile error in the native code because the
getWhatevermethod names will change. However, we won't get errors during compile for the typescript side unless we also someone automatically generate a ts.d for this built-in from the capnp definitions.