Skip to content

Disable memory leak assert that triggers in asan tests. #3215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 6, 2024
Merged

Disable memory leak assert that triggers in asan tests. #3215

merged 2 commits into from
Dec 6, 2024

Conversation

erikcorry
Copy link
Contributor

This is a leak when the whole V8 VM is shut down. Disabled until we work out why we are leaking on shutdown.

@erikcorry
Disable memory leak assert that triggers in asan tests.
6fe7660 
This is a leak when the whole V8 VM is shut down.  Disabled
until we work out why we are leaking on shutdown.
@erikcorry erikcorry requested review from a team as code owners December 5, 2024 21:17
@erikcorry erikcorry merged commit 978fc5b into main Dec 6, 2024
15 checks passed
@erikcorry erikcorry deleted the ecorry/disable-v8-shutdown-assert branch December 6, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@danlapid danlapid danlapid approved these changes

@garrettgu10 garrettgu10 Awaiting requested review from garrettgu10 garrettgu10 is a code owner automatically assigned from cloudflare/workers-runtime-1

@tewaro tewaro Awaiting requested review from tewaro tewaro is a code owner automatically assigned from cloudflare/workers-runtime-1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erikcorry @anonrig @danlapid