Enable using context-specific typewrapper instances. #3194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlapid
changed the title
danlapid
force-pushed
the
dlapid/new_wrapper_for_context
branch
from
0ef2816 to
49f1368
Compare
danlapid
commented
Nov 29, 2024
danlapid
commented
Nov 29, 2024
danlapid
force-pushed
the
dlapid/new_wrapper_for_context
branch
6 times, most recently
from
b9369dc to
9490a98
Compare
danlapid
changed the title
danlapid
changed the title
danlapid
commented
Nov 30, 2024
danlapid
force-pushed
the
dlapid/new_wrapper_for_context
branch
2 times, most recently
from
bced90f to
abb88ce
Compare
|
Hey @jasnell @kentonv I did my best to ensure the case where we never needed a second typewrapper doesn't see any performance regressions. The types check GitHub check is failing just because I need to rebase, I'll do that after the review since there's no significant changes to the types in this PR. |
kentonv
reviewed
Dec 2, 2024
kentonv
reviewed
Dec 2, 2024
|
Approach seems reasonable, just some nitpick comments. |
danlapid
force-pushed
the
dlapid/new_wrapper_for_context
branch
6 times, most recently
from
3cf57d4 to
a597983
Compare
danlapid
force-pushed
the
dlapid/new_wrapper_for_context
branch
from
a597983 to
afa5410
Compare
|
Last push was just a rebase. |
kentonv
reviewed
Dec 6, 2024
kentonv
reviewed
Dec 6, 2024
kentonv
approved these changes
Dec 6, 2024
danlapid
force-pushed
the
dlapid/new_wrapper_for_context
branch
from
c16e90f to
9c25460
Compare
|
Added a fixup with pr fixups in |
Sometimes we'd like to have multiple contexts with different typewrapper that were instantiated with different configuration objects. To do that this commit extends the Isolate class, wrapper is now a vector of wrappers, the 0 indexed wrapper is the default wrapper but additional wrappers can be created with `instantiateWrapper` which receives a new Configuration object. To associate a context with its wrapper we use `context->SetAlignedPointerInEmbedderData(3, wrapper)`.
danlapid
force-pushed
the
dlapid/new_wrapper_for_context
branch
from
9c25460 to
32191ee
Compare
|
Last push merged fixups |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two commits:
Sometimes we'd like to have multiple contexts with different
typewrapper that were instantiated with different configuration objects.
To do that this commit extends the Isolate class, wrapper is now a
vector of wrappers, the 0 indexed wrapper is the default wrapper but
additional wrappers can be created with
instantiateWrapperwhichreceives a new Configuration object. To associate a context with its
wrapper we use
context->SetAlignedPointerInEmbedderData(3, wrapper).