Log outputGate broken shouldRetryCountsAgainstLimits for alarms #3185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jqmmes
force-pushed
the
joaquim/treat-exceeded-memory-during-alarm-as-user-error
branch
2 times, most recently
from
2b3f34b to
8e07c24
Compare
MellowYarker
approved these changes
Nov 28, 2024
jqmmes
force-pushed
the
joaquim/treat-exceeded-memory-during-alarm-as-user-error
branch
from
fc4b7fa to
e3d9af7
Compare
…e exceeded memory overloaded error to be treated as user error
jqmmes
force-pushed
the
joaquim/treat-exceeded-memory-during-alarm-as-user-error
branch
from
9291835 to
d76d464
Compare
jqmmes
deleted the
joaquim/treat-exceeded-memory-during-alarm-as-user-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some overloaded exceptions that are set as
EXCEPTION_IS_USER_ERROR. These errors should be reported back to the alarm-manager as user errors, but some are being reported as internal errors.This PR adds additional logging and does a hackish check to enforce that
broken.exceededMemoryerrors during the alarm execution are treated as user errors.