Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update R2/KJ to avoid mod-after-put when using ArrayBuffer" #314

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

kentonv
Copy link
Member

@kentonv kentonv commented Jan 25, 2023

Reverts #309

This change was merged prematurely, the team hasn't reached consensus on this approach. Some possible concerns:

  • What is the performance impact of copying? Is it worth the cost to force copying on existing users?
  • Is detaching ArrayBuffers a good API? Will it possibly confuse people who are trying to pass the same ArrayBuffer to multiple calls?

It's possible we'll re-land this exactly the same once we've talked this through.

@kentonv kentonv requested a review from jasnell January 25, 2023 01:59
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this or #313.

@kentonv
Copy link
Member Author

kentonv commented Jan 25, 2023

I am personally leaning towards #313 as the end state but I'm sufficiently uncertain that I'd really like to poll the team for thoughts first.

@kentonv kentonv merged commit 0adecf3 into main Jan 25, 2023
@kentonv kentonv deleted the revert-309-jsnell/avoid-mod-after-call-kv-r2 branch January 25, 2023 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants