[CI] Fix architecture for macOS releases #3135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The macOS-cross setup got applied to all release jobs, apparently due to a malformed if condition. Avoid having such a condition entirely.
anonrig
approved these changes
Nov 18, 2024
fhanau
added a commit
that referenced
this pull request
Nov 18, 2024
With #3135 Apple Silicon release artifacts are being created properly, add them to tagged releases too. Xcode 16 appears to be required to build V8 starting with the 13.1 release, update the README to reflect this.
fhanau
added a commit
that referenced
this pull request
Nov 18, 2024
With #3135 Apple Silicon release artifacts are being created properly, add them to tagged releases too. Xcode 16 appears to be required to build V8 starting with the 13.1 release, update the README to reflect this.
fhanau
added a commit
that referenced
this pull request
Nov 25, 2024
With #3135 Apple Silicon release artifacts are being created properly, add them to tagged releases too. Xcode 16 appears to be required to build V8 starting with the 13.1 release, update the README to reflect this.
danlapid
pushed a commit
that referenced
this pull request
Dec 3, 2024
With #3135 Apple Silicon release artifacts are being created properly, add them to tagged releases too. Xcode 16 appears to be required to build V8 starting with the 13.1 release, update the README to reflect this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have two separate macOS release builds, but the macOS-cross setup got applied to all release jobs, apparently due to a malformed if condition. Avoid having such a condition entirely.