Give DurableObjectStorage reference to primary #3112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MellowYarker
force-pushed
the
jmp/context-storage-primary-property
branch
2 times, most recently
from
11c21c1 to
1f9dbdd
Compare
MellowYarker
changed the title
|
@justin-mp alright if I consolidate to 1 commit and mark you as a co-author? |
Fine with me. |
jasnell
reviewed
Nov 20, 2024
jasnell
approved these changes
Nov 20, 2024
jasnell
approved these changes
Nov 20, 2024
jasnell
approved these changes
Nov 20, 2024
|
A PR so nice I approved it thrice.
Really not sure what happened here, Github. |
justin-mp
reviewed
Nov 20, 2024
justin-mp
approved these changes
Nov 20, 2024
MellowYarker
force-pushed
the
jmp/context-storage-primary-property
branch
from
1f9dbdd to
c24ddff
Compare
MellowYarker
force-pushed
the
jmp/context-storage-primary-property
branch
from
c24ddff to
b42c3ed
Compare
We give a replica DO access to its primary through a DurableObject stub. This is a pretty big departure from our typical stub creation flow. Usually we need to make an ActorChannel with an outgoing factory, which needs to make an outgoing request (internally) to get a capability to the receiving Durable Object. In this case, we already have our capability to the primary Durable Object once the ActorCacheInterface is up and running. Therefore, all we need to do is create an ActorChannel and give it access to the ActorCacheInterface, which will take care of the rest (internally). Co-authored-by: Justin Mazzola Paluska <[email protected]>
MellowYarker
force-pushed
the
jmp/context-storage-primary-property
branch
from
b42c3ed to
37cf21c
Compare
|
FYI, this build was merged with CI failing. It was an "optional" CI build, but the failure was in fact caused by this change and so should have been considered blocking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.