Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "stack-trace symbolizer using llvm-symbolizer subprocess" #310

Conversation

ObsidianMinor
Copy link
Collaborator

Reverts #297

This broken an internal build. Somehow.

@github-actions
Copy link

github-actions bot commented Jan 24, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@ObsidianMinor
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

@ObsidianMinor
Copy link
Collaborator Author

Oh now you accept that I've signed the CLA

@ObsidianMinor
Copy link
Collaborator Author

@mikea fyi

@dom96
Copy link
Collaborator

dom96 commented Jan 24, 2023

hm, seems the CI is taking a long time. I see cache errors in the logs, I guess the cache is down or @ObsidianMinor doesn't have access to it?

@harrishancock
Copy link
Collaborator

He doesn't have access (yet). cc @byule

@harrishancock harrishancock self-requested a review January 24, 2023 12:10
@harrishancock harrishancock merged commit a7fe1f0 into cloudflare:main Jan 24, 2023
@ObsidianMinor ObsidianMinor deleted the revert-297-maizatskyi/2023-01-19-symbolizer branch January 24, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants