-
Notifications
You must be signed in to change notification settings - Fork 358
Upgrade V8 13.0.245.16 -> 13.1.201.8 #3093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
LGTM – I assumed that we'd have to set |
90474a2
to
210c23f
Compare
@ObsidianMinor can we get this passing and merged please? |
I ran around for 2 days until I eventually got it compiled locally and ran it under WinDbg just to find it it's broken and was only fixed here v8/v8@f8bb2d4 |
Not even backporting the fix to 13.1, that's just mean |
50dce5f
to
ad3e08f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this ends up being the fix tag Mike to let him know he should remove this patch when updating to 13.2 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe git will automatically remove the commit since the patch already exists upstream? It should happen during the rebase. But I'll make sure to mention it.
ad3e08f
to
bb1d560
Compare
@ObsidianMinor gg wp |
Includes the
WebAssembly.compile
behavior patch.