Skip to content

Upgrade V8 13.0.245.16 -> 13.1.201.8 #3093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Conversation

ObsidianMinor
Copy link
Contributor

Includes the WebAssembly.compile behavior patch.

@ObsidianMinor ObsidianMinor requested review from a team as code owners November 12, 2024 00:46
@fhanau
Copy link
Contributor

fhanau commented Nov 12, 2024

  • In WORKSPACE, absl should be updated to the commit used by V8 13.1 (dc257ad54f38739767a6cb26eb57fd51c37bfe3c)

@fhanau
Copy link
Contributor

fhanau commented Nov 12, 2024

LGTM – I assumed that we'd have to set --@v8//:v8_wasm_random_fuzzers=false here to benefit from https://chromium-review.googlesource.com/c/v8/v8/+/5873224, it seems to be off-by-default though. There are some new defines like CPPGC_ENABLE_API_CHECKS too, but it looks like they don't require manual handling either.

@danlapid
Copy link
Collaborator

@ObsidianMinor can we get this passing and merged please?

@ObsidianMinor
Copy link
Contributor Author

I ran around for 2 days until I eventually got it compiled locally and ran it under WinDbg just to find it it's broken and was only fixed here v8/v8@f8bb2d4

@danlapid
Copy link
Collaborator

I ran around for 2 days until I eventually got it compiled locally and ran it under WinDbg just to find it it's broken and was only fixed here v8/v8@f8bb2d4

Not even backporting the fix to 13.1, that's just mean

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this ends up being the fix tag Mike to let him know he should remove this patch when updating to 13.2 🙏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe git will automatically remove the commit since the patch already exists upstream? It should happen during the rebase. But I'll make sure to mention it.

@danlapid
Copy link
Collaborator

@ObsidianMinor gg wp

@ObsidianMinor ObsidianMinor merged commit a8c1bf9 into main Nov 16, 2024
14 checks passed
@ObsidianMinor ObsidianMinor deleted the chore/v8-13.1-upgrade branch November 16, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants