Neuter the EncodedAsyncOutputStream on end/abort #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because kj::AsyncOutputStream does not have an explicit end, some impls use their destructor to perform final writes, some of those using held bare refs to other objects. If the EncodedAsyncOutputStream happens to be held by an IoOwn (or some other mechanism that extends its lifetime past that of those deeply nested bare refs) then we can have a problem. Here, we modify EncodedAsyncOutputStream to free inner when either end or abort are called, effectively neutering it and allowing the inner to perform any additional cleanup it needs on end.
jasnell
approved these changes
Jan 23, 2023
kentonv
reviewed
Jan 25, 2023
| } | ||
|
|
||
| KJ_IF_MAYBE(stream, inner.tryGet<kj::Own<kj::AsyncOutputStream>>()) { | ||
| if (auto casted = dynamic_cast<kj::AsyncIoStream*>(stream->get())) { | ||
| casted->shutdownWrite(); | ||
| } | ||
| promise = promise.attach(kj::mv(*stream)); |
There was a problem hiding this comment.
This line is redundant FWIW -- promise is always READY_NOW here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original commit description by @jasnell:
Because kj::AsyncOutputStream does not have an explicit end, some impls use their destructor to perform final writes, some of those using held bare refs to other objects. If the EncodedAsyncOutputStream happens to be held by an IoOwn (or some other mechanism that extends its lifetime past that of those deeply nested bare refs) then we can have a problem.
Here, we modify EncodedAsyncOutputStream to free inner when either end or abort are called, effectively neutering it and allowing the inner to perform any additional cleanup it needs on end.