Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQC-333: Support Hyperdrive with SSL in dev mode #3037

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

ReppCodes
Copy link
Contributor

We have historically used sslmode=disable in when running wrangler dev, with the intention of not forcing folks to set up SSL on a local test DB. Unfortunately this causes friction because many hosted databases will have SSL set up and required, and Hyperdrive in production actually requires this. To improve flexibilty, switch to prefer mode which will use SSL if available for a close-to-production experience, but will allow unencrypted connections if needed.

@ReppCodes ReppCodes requested review from a team as code owners October 31, 2024 16:41
@ReppCodes ReppCodes requested review from dom96 and jasnell October 31, 2024 16:41
Copy link

github-actions bot commented Oct 31, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@ReppCodes
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Oct 31, 2024
Copy link
Contributor

@thomasgauvin thomasgauvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@anonrig anonrig merged commit 1149737 into cloudflare:main Nov 5, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants