Move ownership of metrics and limitEnforcer to the api type. #3034
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
danlapid
force-pushed
the
dlapid/ownership_cleanups_for_pools
branch
2 times, most recently
from
ee2b913 to
e347c69
Compare
danlapid
force-pushed
the
dlapid/ownership_cleanups_for_pools
branch
from
e347c69 to
6dd801a
Compare
Currently ownership is shared even though the Isolate class encapsulates the api class. Moving complete ownership to the underlying api class allows the isolate class to be constructed in a different scope to the api class. This is useful for preinitialization of the api class before a request has come in.
danlapid
force-pushed
the
dlapid/ownership_cleanups_for_pools
branch
from
6dd801a to
a9fd4fc
Compare
| jsgIsolate.runInLockScope( | ||
| [&](JsgWorkerdIsolate::Lock& lock) { limitEnforcer->customizeIsolate(lock.v8Isolate); }); |
There was a problem hiding this comment.
In the previous version of the code this is run under jsg::runInV8Stack, I assume doing this here under runInLockScope is equivalent.
There was a problem hiding this comment.
Yeah, it's a utility function that translates to the same thing :)
Yep you're right, that change is indeed intended, we're going to be using this isolate before we have an |
Enable const variants of some const-safe jsg functions.
Move ownership of metrics and limitEnforcer to the api type.
This PR has no real function and should not change anything of itself.
Instead it's just another part of the work to enable python isolate pools.
This PR does some cleanup that will later enable us to create an isolate without the data that only becomes available once we have a request.
There is also a corresponding internal PR 9105