Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WPT urlpattern tests #3030

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Add WPT urlpattern tests #3030

merged 1 commit into from
Oct 30, 2024

Conversation

npaun
Copy link
Member

@npaun npaun commented Oct 30, 2024

These tests were a bit clunky to add because the actual test code is in the resources/ directory, and the typical *.any.js files are empty and contain only some comments.

New test cases:

  • urlpattern-compare-tests.js
  • urlpattern-hasregexpgroups-tests.js
  • urlpatterntests.js

New harness features:

  • assert_object_equals
  • assert_implements

@npaun npaun requested review from jasnell and anonrig October 30, 2024 18:11
@npaun npaun requested review from a team as code owners October 30, 2024 18:11
@npaun npaun mentioned this pull request Oct 30, 2024
8 tasks
@npaun npaun force-pushed the npaun/wpt-urlpattern branch from 5153ac4 to 72dfcf8 Compare October 30, 2024 18:55
@npaun npaun merged commit 6c841e4 into main Oct 30, 2024
13 checks passed
@npaun npaun deleted the npaun/wpt-urlpattern branch October 30, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants