Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PumpToReader stay on its own IoContext #298

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Make PumpToReader stay on its own IoContext #298

merged 1 commit into from
Jan 23, 2023

Conversation

harrishancock
Copy link
Collaborator

Also, add a new awaitIo() overload which accepts a callback and errorback, which we need here.

@harrishancock harrishancock requested a review from jasnell January 20, 2023 15:02
@harrishancock harrishancock merged commit 7e94d3e into main Jan 23, 2023
@harrishancock harrishancock deleted the harris/keep-pump-to-reader-on-iocontext branch January 23, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harrishancock @jasnell