[nfc] Update to python 3.13, minor python and TS cleanup #2965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fhanau
commented
Oct 21, 2024
•
fhanau
commented
- Update rules_python, facilitating python 3.13 update
- Remove actions/setup-python from lint.yml – python 3.12 already ships on the Ubuntu 24.04 runner.
- Update python deps (markupsafe)
- Refactor wd_test macro and tsconfig so that we can define TypeScript-based JS tests without having to manually define a ts_project
fhanau
commented
Oct 21, 2024
| @@ -19,9 +19,6 @@ jobs: | |||
| - uses: actions/checkout@v4 | |||
| with: | |||
| show-progress: false | |||
| - uses: actions/setup-python@v5 | |||
There was a problem hiding this comment.
@hoodmane I know this was added intentionally, but the Ubuntu 24.04 image already comes with python 3.12. I'm open to keeping this if you see a need for it despite that, or if the lint script would benefit from python 3.13 (developers won't have access to 3.13 for now so I guess that's a reason to not depend on it).
There was a problem hiding this comment.
Removing seems fine to me, no strong feelings.
fhanau
commented
Oct 21, 2024
| @@ -11,7 +11,8 @@ | |||
| }, | |||
| "composite": true, | |||
| "declaration": true, | |||
| "skipLibCheck": true | |||
| "skipLibCheck": true, | |||
| "allowJs": true | |||
There was a problem hiding this comment.
allowJs added to match ts_project in wd_test – this is not needed now but we might have wd_tests using both JS + TS in the future.
- Update rules_python, facilitating python 3.13 update - Remove actions/setup-python from lint.yml – python 3.12 already ships on the Ubuntu 24.04 runner. - Update python deps (markupsafe) - Refactor wd_test macro and tsconfig so that we can define TypeScript-based JS tests without having to manually define a ts_project
fhanau
force-pushed
the
felix/python-ts-cleanup
branch
from
c97ce2a to
fec9b38
Compare
fhanau
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.